Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: update invenio-sip2 #2148

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Jul 12, 2021

  • Updates poetry.lock.
  • Fixes missing language and translation.
  • Adds alert message when item is requested.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d added the dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed label Jul 12, 2021
@lauren-d lauren-d self-assigned this Jul 12, 2021
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Jul 13, 2021
@lauren-d lauren-d force-pushed the lau-sip2-debug branch 2 times, most recently from 5cac621 to 93eeeaa Compare July 13, 2021 19:00
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

* Updates poetry.lock.
* Fixes missing language and translation.
* Adds alert message when item is requested.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d merged commit f4920cb into rero:dev Jul 15, 2021
@iGormilhit iGormilhit added this to the v1.4.3 milestone Jul 15, 2021
@lauren-d lauren-d deleted the lau-sip2-debug branch September 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants