Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: fix missing ILL request menu #2119

Merged
merged 1 commit into from
Jul 6, 2021
Merged

theme: fix missing ILL request menu #2119

merged 1 commit into from
Jul 6, 2021

Conversation

iGormilhit
Copy link

  • Restores the ILL request menu after the implementation of the
    statistics menu available to an administrator. Issue spotted on the
    v1.4.0 release candidate (see v1.4.0 RC bug list #2118).

Co-Authored-by: Igor Milhit [email protected]

Why are you opening this PR?

  • To fix the missing ILL request menu.

How to test?

  1. Log in as a patron and check that the ILL request menu is still there.
  2. Navigate to an organisation view, and check that the collection menu is
    still there.
  3. Log in as and administrator and check that the statistics menu is available.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

theme: fix missing ILL request menu
090f1bf 
* Restores the ILL request menu after the implementation of the
  statistics menu available to an administrator. Issue spotted on the
  `v1.4.0` release candidate (see #2118).

Co-Authored-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit self-assigned this Jul 6, 2021
@github-actions github-actions bot added the f: public ui Public interface, as opposed to the professional interface label Jul 6, 2021
@iGormilhit iGormilhit mentioned this pull request Jul 6, 2021
Closed
11 tasks
@iGormilhit iGormilhit requested a review from zannkukai July 6, 2021 05:45
@iGormilhit iGormilhit added this to the v1.4.0 milestone Jul 6, 2021
@iGormilhit iGormilhit merged commit 1887e9d into rero:dev Jul 6, 2021
@iGormilhit iGormilhit deleted the fix-ill-request-menu branch July 15, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@jma jma Awaiting requested review from jma

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees

@iGormilhit iGormilhit

Labels
f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@iGormilhit @zannkukai @benerken