Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patrons: allow to update user and patron records #2086

Merged
merged 1 commit into from
Jun 29, 2021
Merged

patrons: allow to update user and patron records #2086

merged 1 commit into from
Jun 29, 2021

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Jun 29, 2021 •
edited
Loading

Fixes a problem when updates to the patron record and
its user record was not possible. With this commit,
the cli to import users is able to update the user and
patron records.

Co-Authored-by: Aly Badr [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added the f: circulation Concerns the circulation interface or backend label Jun 29, 2021
@BadrAly BadrAly added this to the v1.4.0 milestone Jun 29, 2021
@BadrAly BadrAly self-assigned this Jun 29, 2021
@github-actions github-actions bot added f: user management and removed f: circulation Concerns the circulation interface or backend labels Jun 29, 2021
@BadrAly BadrAly force-pushed the baa-update-patron-cli branch 2 times, most recently from 3c7498c to c80ecfe Compare June 29, 2021 11:39
jma
jma approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put more details on the commit message.

@BadrAly BadrAly force-pushed the baa-update-patron-cli branch from c80ecfe to f206151 Compare June 29, 2021 11:50
@BadrAly BadrAly requested review from zannkukai and iGormilhit June 29, 2021 13:08
@iGormilhit iGormilhit changed the title patrons: allow update of user and patron records patrons: allow to update user and patron records Jun 29, 2021
patrons: allow to update user and patron records
56f40b8 
Fixes a problem when updates to the patron record and
its user record was not possible. With this commit,
the cli to import users is able to update the user and
patron records.

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the baa-update-patron-cli branch from f206151 to 56f40b8 Compare June 29, 2021 13:23
@iGormilhit iGormilhit added the f: data migration Data migration from a legacy system or a previous version label Jun 29, 2021
@BadrAly BadrAly merged commit db4a27b into rero:dev Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees

@BadrAly BadrAly

Labels
f: data migration Data migration from a legacy system or a previous version f: user management
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BadrAly @jma @iGormilhit @zannkukai