Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring: fix ES duplicate display #2081

Merged
merged 1 commit into from
Jun 28, 2021
Merged

monitoring: fix ES duplicate display #2081

merged 1 commit into from
Jun 28, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jun 25, 2021

Co-Authored-by: Peter weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Jun 26, 2021
@rerowep rerowep added bug Breaks something but is not blocking dev: monitoring Alert system like Sentry or Zabbix. labels Jun 26, 2021
@iGormilhit iGormilhit changed the title monitor: fix ES duplicate display monitoring: fix ES duplicate display Jun 28, 2021
iGormilhit
iGormilhit reviewed Jun 28, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title: s/monitor/monitoring/

@iGormilhit iGormilhit added this to the v1.4.0 milestone Jun 28, 2021
@rerowep rerowep requested a review from iGormilhit June 28, 2021 06:18
@rerowep rerowep merged commit d32a45f into rero:dev Jun 28, 2021
@rerowep rerowep deleted the wep-fix-monitor branch June 28, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking dev: monitoring Alert system like Sentry or Zabbix.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @Garfield-fr @iGormilhit @zannkukai