circulation: fix can_extend check method
#2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: circulation
Garfield-fr
approved these changes
Jun 16, 2021
iGormilhit
approved these changes
Jun 16, 2021
BadrAly
approved these changes
Jun 16, 2021
zannkukai
force-pushed
the
zan-fix-extend-loan
branch
from
d20c995 to
e4082c1
Compare
lauren-d
approved these changes
Jun 16, 2021
zannkukai
force-pushed
the
zan-fix-extend-loan
branch
3 times, most recently
from
5ff2896 to
3c794fc
Compare
Sometimes, no loan parameter could be send to `can_extend` method. In this case, the function skip all checks and return True. Now this function try to load the loan based on others function arguments to be more relevant. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-fix-extend-loan
branch
from
3c794fc to
017acd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, no loan parameter could be send to
can_extendmethod. Inthis case, the function skip all checks and return True. Now this
function try to load the loan based on others function arguments to be
more relevant.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list