Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: add missing mappings #1925

Merged
merged 1 commit into from
May 18, 2021
Merged

search: add missing mappings #1925

merged 1 commit into from
May 18, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented May 15, 2021 •
edited by pronguen
Loading

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this May 15, 2021
@rerowep rerowep force-pushed the wep-add-missing-mappings branch from ac3589f to 2819fa7 Compare May 15, 2021 14:13
iGormilhit
iGormilhit suggested changes May 17, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message: Adds missing elsaric search mappings → Adds missing Elastic Search mappings.

data/ill_requests.json Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-add-missing-mappings branch from 2819fa7 to ecfc1a1 Compare May 17, 2021 15:17
@rerowep rerowep requested a review from iGormilhit May 17, 2021 22:13
@rerowep rerowep force-pushed the wep-add-missing-mappings branch from ecfc1a1 to c3a8ae3 Compare May 17, 2021 22:13
@rerowep rerowep added this to the v1.3.0 milestone May 18, 2021
@rerowep
search: add missing mappings
8c0b0a6 
* Adds missing Elastic Search mappings.
* Closes rero#1873, last bullet point of rero#1873 (comment).

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-add-missing-mappings branch from c3a8ae3 to 8c0b0a6 Compare May 18, 2021 08:43
@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: circulation Concerns the circulation interface or backend f: user management labels May 18, 2021
@rerowep rerowep merged commit 0c55f94 into rero:dev May 18, 2021
@rerowep rerowep deleted the wep-add-missing-mappings branch May 18, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@jma jma Awaiting requested review from jma

@sebdeleze sebdeleze Awaiting requested review from sebdeleze

Assignees

@rerowep rerowep

Labels
f: acquisitions Related to the acquisition module f: circulation Concerns the circulation interface or backend f: search f: user management
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Bug list for the v1.2.0 RC
4 participants
@rerowep @iGormilhit @zannkukai @benerken