Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: restrict ILL request form to patron #1910

Merged
merged 1 commit into from
May 28, 2021
Merged

circulation: restrict ILL request form to patron #1910

merged 1 commit into from
May 28, 2021

Conversation

zannkukai
Copy link
Contributor

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this May 11, 2021
@zannkukai zannkukai added bug Breaks something but is not blocking f: permissions Concerns the rights management f: public ui Public interface, as opposed to the professional interface labels May 11, 2021
Garfield-fr
Garfield-fr reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@Garfield-fr Garfield-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to protect the access on the url

@zannkukai zannkukai force-pushed the zan-fix-issue-1895 branch from fa5462c to 6f2cf36 Compare May 11, 2021 05:56
@iGormilhit iGormilhit changed the title general: restrict ILL request form to patron circulation: restrict ILL request form to patron May 25, 2021
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: user management labels May 25, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone May 25, 2021
iGormilhit
iGormilhit reviewed May 25, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit title component: from general to circulation.

@zannkukai
general: restrict ILL request form to patron
3c86a94 
* The "ILLRequest form" user menu entry is now only visible if the
  current logged user has the `patron` role.
* Closes rero#1895.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-fix-issue-1895 branch from 6f2cf36 to 3c86a94 Compare May 27, 2021 14:21
@zannkukai zannkukai merged commit 33a90ce into rero:dev May 28, 2021
@zannkukai zannkukai deleted the zan-fix-issue-1895 branch May 28, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr left review comments

@iGormilhit iGormilhit iGormilhit left review comments

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: permissions Concerns the rights management f: public ui Public interface, as opposed to the professional interface f: user management
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Logged user without the patron role should not be able to edit the ILL request form
4 participants
@zannkukai @Garfield-fr @iGormilhit @lauren-d