Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributions: restore missing Jinja templates #1874

Merged
merged 1 commit into from
May 5, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented May 4, 2021

  • Restores the contribution Jinja templates detailed view.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma jma added this to the v1.2.0 milestone May 4, 2021
@jma jma requested a review from iGormilhit May 4, 2021 14:18
@iGormilhit iGormilhit added bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface labels May 4, 2021
@iGormilhit iGormilhit mentioned this pull request May 4, 2021
6 tasks
@jma jma force-pushed the maj-restore-contribution-templates branch from 9cb48d0 to 3e48e63 Compare May 4, 2021 19:46
* Restores the contribution Jinja templates detailed view.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-restore-contribution-templates branch from 3e48e63 to d442e3e Compare May 5, 2021 04:55
@jma jma merged commit 12b4758 into rero:dev May 5, 2021
@jma jma deleted the maj-restore-contribution-templates branch January 13, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants