Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: import, export, create csv data files #1710

Merged
merged 1 commit into from
May 10, 2021
Merged

metadata: import, export, create csv data files #1710

merged 1 commit into from
May 10, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 18, 2021

  • Implements import and export of resources in csv format.
  • Implements creation of csv files from json files.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Feb 18, 2021
@rerowep rerowep marked this pull request as draft February 18, 2021 19:42
@rerowep rerowep force-pushed the wep-csv branch 16 times, most recently from 3003310 to 0cfc392 Compare February 25, 2021 08:49
@rerowep rerowep marked this pull request as ready for review February 26, 2021 08:20
@rerowep rerowep force-pushed the wep-csv branch 2 times, most recently from 4156c70 to dde6828 Compare March 1, 2021 08:02
@iGormilhit iGormilhit changed the title metadata: import, export, create csv metadata: import, export, create csv data files Mar 1, 2021
iGormilhit
iGormilhit reviewed Mar 1, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title: metadata: import, export, create csv data files

zannkukai
zannkukai reviewed Mar 2, 2021
View reviewed changes
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-csv branch 2 times, most recently from d148319 to 0f11511 Compare March 4, 2021 13:26
@rerowep rerowep force-pushed the wep-csv branch 4 times, most recently from 1f9c533 to b85ed21 Compare April 4, 2021 21:04
@rerowep rerowep force-pushed the wep-csv branch 2 times, most recently from b24b723 to ac5cdba Compare April 13, 2021 08:30
@rerowep rerowep requested review from jma, zannkukai and lauren-d April 13, 2021 14:17
lauren-d
lauren-d approved these changes Apr 13, 2021
View reviewed changes
rero_ils/modules/api.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-csv branch 2 times, most recently from c7ab383 to 286303f Compare April 23, 2021 19:49
@iGormilhit iGormilhit added the f: data migration Data migration from a legacy system or a previous version label Apr 27, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Apr 27, 2021
@rerowep rerowep force-pushed the wep-csv branch 2 times, most recently from cfb9f22 to 58c053f Compare May 3, 2021 18:52
@jma jma removed their request for review May 4, 2021 05:53
@rerowep
metadata: import, export, create csv data files
03591bf 
* Implements import and export of resources in csv format.
* Implements creation of csv files from json files.
* Changes from sqlite to postgres as test DB.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep merged commit d54c20f into rero:dev May 10, 2021
@rerowep rerowep deleted the wep-csv branch May 10, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@lauren-d lauren-d lauren-d approved these changes

Assignees

@rerowep rerowep

Labels
f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @iGormilhit @zannkukai @BadrAly @lauren-d