libraries: add notification settings in library definition #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#2012-printing-email
branch
5 times, most recently
from
1f3f646 to
cde5544
Compare
AoNoOokami
force-pushed
the
zaa-#2012-printing-email
branch
3 times, most recently
from
538b402 to
73372b5
Compare
7 tasks
jma
force-pushed
the
zaa-#2012-printing-email
branch
from
73372b5 to
fac2a5b
Compare
jma
force-pushed
the
zaa-#2012-printing-email
branch
2 times, most recently
from
f18f10e to
8797836
Compare
zannkukai
approved these changes
Mar 12, 2021
rero_ils/modules/libraries/api.py
Outdated
| @@ -358,6 +358,11 @@ def get_timezone(self): | |||
| default = pytz.timezone('Europe/Zurich') | |||
| return default | |||
|
|
|||
| def email_notification_type(self, notification_type): | |||
| """.""" | |||
There was a problem hiding this comment.
I like this docstring ! 😍 but seems not according to best practices :-)
jma
force-pushed
the
zaa-#2012-printing-email
branch
from
8797836 to
d42d5af
Compare
rerowep
approved these changes
Mar 15, 2021
jma
force-pushed
the
zaa-#2012-printing-email
branch
from
d42d5af to
97649a7
Compare
benerken
approved these changes
Mar 15, 2021
jma
force-pushed
the
zaa-#2012-printing-email
branch
2 times, most recently
from
706c281 to
c9287f2
Compare
* Adds notification settings in library jsonschema and mapping. * Adds notification settings data. * For patron with mail communication channel the notification is sent to the corresponding library email if it exists. * Closes rero#913. * Adds patron information for each email sent to the library emails. Co-Authored-by: Alicia Zangger <[email protected]> Co-Authored-by: Renaud Michotte <[email protected]> Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
force-pushed
the
zaa-#2012-printing-email
branch
from
c9287f2 to
5827225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the corresponding library email if it exists.
Co-Authored-by: Alicia Zangger [email protected]
Co-Authored-by: Renaud Michotte [email protected]
Co-Authored-by: Johnny Mariéthoz [email protected]
Why are you opening this PR?
To implement task 2012 of US1922 https://tree.taiga.io/project/rero21-reroils/us/1922?milestone=282105
Dependencies
Code review check list