Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: upgrade invenio to version 3.4 #1581

Merged
merged 1 commit into from
Jan 20, 2021
Merged

dependencies: upgrade invenio to version 3.4 #1581

merged 1 commit into from
Jan 20, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Dec 23, 2020

  • Upgrades to invenio 3.4.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep requested review from jma and iGormilhit December 23, 2020 19:20
@rerowep rerowep self-assigned this Dec 23, 2020
@rerowep rerowep force-pushed the wep-invenio-3.4 branch 2 times, most recently from c1d9253 to 15501d6 Compare December 23, 2020 22:23
@rerowep rerowep force-pushed the wep-invenio-3.4 branch 5 times, most recently from b48bb04 to 5b775c0 Compare December 24, 2020 00:03
@rerowep rerowep marked this pull request as draft December 24, 2020 21:44
@rerowep rerowep force-pushed the wep-invenio-3.4 branch 15 times, most recently from 3260fdc to 72e4565 Compare December 28, 2020 17:29
@rerowep rerowep marked this pull request as ready for review December 28, 2020 18:44
@rerowep rerowep force-pushed the wep-invenio-3.4 branch 3 times, most recently from f89c228 to 19933a5 Compare December 31, 2020 13:03
zannkukai
zannkukai approved these changes Jan 6, 2021
View reviewed changes
rero_ils/modules/items/api/issue.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-invenio-3.4 branch 4 times, most recently from 6c7aa9f to 85a5754 Compare January 11, 2021 07:34
@iGormilhit iGormilhit added the dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed label Jan 12, 2021
@iGormilhit iGormilhit added this to the v1.0.0 milestone Jan 12, 2021
iGormilhit
iGormilhit approved these changes Jan 12, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

jma
jma requested changes Jan 12, 2021
View reviewed changes
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pytest.ini Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/modules/holdings/cli.py Show resolved Hide resolved
rero_ils/modules/ill_requests/templates/rero_ils/ill_request_form.html Show resolved Hide resolved
rero_ils/modules/items/api/circulation.py Show resolved Hide resolved
rero_ils/theme/templates/rero_ils/search.html Show resolved Hide resolved
rero_ils/theme/templates/rero_ils/javascript.html Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-invenio-3.4 branch 5 times, most recently from a574ab3 to 185eb0e Compare January 14, 2021 08:53
@iGormilhit iGormilhit changed the title dependencies: invenio 3.4 dependencies: upgrade invenio to version 3.4 Jan 18, 2021
@rerowep
dependencies: upgrade invenio to version 3.4
3a12118 
* Adds count display during holding creation.
* Cleans ill_request_form.html file.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep merged commit 132280e into rero:dev Jan 20, 2021
@rerowep rerowep deleted the wep-invenio-3.4 branch January 20, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees

@rerowep rerowep

Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @jma @iGormilhit @zannkukai @BadrAly