Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: fix broken collection search page #1567

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 16, 2020

  • Removes specific view and templates for collection search and use the
    the general public search view and templates.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma jma marked this pull request as ready for review December 16, 2020 10:07
* Removes specific view and templates for collection search and use the
  the general public search view and templates.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-collection-search-page branch from ece045d to cf5fad2 Compare December 16, 2020 10:14
@jma jma changed the title search: fix collection search page broken search: fix broken collection search page Dec 16, 2020
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@jma jma merged commit e2dec45 into rero:dev Dec 16, 2020
@jma jma deleted the maj-fix-collection-search-page branch January 13, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants