Implement SIP2 checkin/checkout actions (US 1357) #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benerken
approved these changes
Dec 2, 2020
lauren-d
force-pushed
the
US1357-sip2-circulation
branch
from
47137c6 to
64aedb7
Compare
Allows the patron to view details of overdue items, checked out items… on the selfcheck machine. To do that, we need to return item information (title, fee amount, due date…) * Upgrades invenio-SIP2 modules version. * Implements item information handlers. * Adapts and write some tests. Co-Authored-by: Lauren-D <[email protected]>
Allows the patron to do a checkout on the selfcheck machine. * Adds checkout handler. * Adds patron status handler. * Adapts and write some tests. * Changes organisation_pid to library_pid used by client. * Adapts invenio-sip2 package to use latest version. Co-Authored-by: Lauren-D <[email protected]> Co-Authored-by: Benoit Erken <[email protected]>
Allows the patron to do a checkin on the selfcheck machine. * Adds checkin handler. * Adapts and write some tests. Co-Authored-by: Lauren-D <[email protected]>
lauren-d
force-pushed
the
US1357-sip2-circulation
branch
from
64aedb7 to
b6b76c2
Compare
Returns checkin or checkout notes to the selfchek machine. * Adds checkout or checkin note to the selfchek handler. * Adds try statement to catch error on patron checkin/checkout Co-Authored-by: Lauren-D <[email protected]>
iGormilhit
changed the title
iGormilhit
added
the
f: circulation
iGormilhit
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Code review check list