Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: check in an item with no loans #1408

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Nov 6, 2020

Fixes a bug when checking in an on_shelf or in_transit item (with no
loans) that did not receive the correct item status.

Co-Authored-by: Aly Badr [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

Fixes a bug when checking in an on_shelf or in_transit item (with no
loans) that did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly self-assigned this Nov 6, 2020
@BadrAly BadrAly added bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend labels Nov 6, 2020
@BadrAly BadrAly added this to the v0.14.0 milestone Nov 6, 2020
@BadrAly BadrAly merged commit f9a4e2d into rero:dev Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item CHECKIN_1_1_2 does not work
4 participants