-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: translations #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources not translated
My account not translated
Person not in plural in german -> Personen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the same context, is it really "Person" in English? If I recall correctly, it is supposed to be "Personal Name" as type of authority not "Person". Other than that, I approve the PR
@BadrAly Is it a translation issue, or a coding issue? The name of the module is @rerowep and @BadrAly But the issue is, that it the same string that's translated and displayed at several places: the admin menu, but also the type of the author of a document (person or organisation), and sometimes it should be plural, others singular. Transifex says:
|
@rerowep On my instance, the header menu are always in french. This is weird, because the translations exists and are in the compiled catalog. |
Yes, but why the french and english is in plural and german in singular ? |
@rerowep Because you proposed this translations in transifex: https://www.transifex.com/rero/reroils/translate/#de/$/154056376?q=text%3A%22pers%22 😄 |
@iGormilhit Ok I have changed it in transiflex ... |
|
I pushed a button here by mistake .. do not know which one. |
@rerowep Thanks for the changes in Transifex. I've updated my PR with your changes. |
* NEW: translates the sprint 11 features * FIX: fix error in the search template * FIX: fix MEF ID diplay on person detailed view Signed-off-by: Igor Milhit <[email protected]>
Signed-off-by: Igor Milhit [email protected]