Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: translations #130

Merged
merged 1 commit into from
Oct 25, 2018
Merged

frontend: translations #130

merged 1 commit into from
Oct 25, 2018

Conversation

iGormilhit
Copy link

  • NEW: translates the sprint 11 features

Signed-off-by: Igor Milhit [email protected]

Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources not translated
My account not translated
Person not in plural in german -> Personen

Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the same context, is it really "Person" in English? If I recall correctly, it is supposed to be "Personal Name" as type of authority not "Person". Other than that, I approve the PR

@iGormilhit
Copy link
Author

@BadrAly Is it a translation issue, or a coding issue? The name of the module is Persons and the resource type is pers. According to US 602, I think it should be persons.

@rerowep and @BadrAly But the issue is, that it the same string that's translated and displayed at several places: the admin menu, but also the type of the author of a document (person or organisation), and sometimes it should be plural, others singular. Transifex says:

Occurences:
rero_ils/modules/documents/form_options/documents/document-v0.0.1.json:108, rero_ils/modules/persons/templates/rero_ils/detailed_view_persons.html:10 

@iGormilhit
Copy link
Author

@rerowep On my instance, the header menu are always in french. This is weird, because the translations exists and are in the compiled catalog.

@rerowep
Copy link
Contributor

rerowep commented Oct 23, 2018

@rerowep and @BadrAly But the issue is, that it the same string that's translated and displayed at several places: the admin menu, but also the type of the author of a document (person or organisation), and sometimes it should be plural, others singular. Transifex says:

Occurences:
rero_ils/modules/documents/form_options/documents/document-v0.0.1.json:108, rero_ils/modules/persons/templates/rero_ils/detailed_view_persons.html:10 

Yes, but why the french and english is in plural and german in singular ?

@iGormilhit
Copy link
Author

@rerowep Because you proposed this translations in transifex: https://www.transifex.com/rero/reroils/translate/#de/$/154056376?q=text%3A%22pers%22 😄

@rerowep
Copy link
Contributor

rerowep commented Oct 23, 2018

@iGormilhit Ok I have changed it in transiflex ...

@BadrAly
Copy link

BadrAly commented Oct 23, 2018

@BadrAly Is it a translation issue, or a coding issue? The name of the module is Persons and the resource type is pers. According to US 602, I think it should be persons.

@rerowep and @BadrAly But the issue is, that it the same string that's translated and displayed at several places: the admin menu, but also the type of the author of a document (person or organisation), and sometimes it should be plural, others singular. Transifex says:

Occurences:
rero_ils/modules/documents/form_options/documents/document-v0.0.1.json:108, rero_ils/modules/persons/templates/rero_ils/detailed_view_persons.html:10 

@BadrAly BadrAly closed this Oct 23, 2018
@BadrAly
Copy link

BadrAly commented Oct 23, 2018

I pushed a button here by mistake .. do not know which one.
@iGormilhit : My comment was related to the translation. but it is not so important, you may ignore.

@BadrAly BadrAly reopened this Oct 23, 2018
@iGormilhit
Copy link
Author

@rerowep Thanks for the changes in Transifex. I've updated my PR with your changes.

* NEW: translates the sprint 11 features
* FIX: fix error in the search template
* FIX: fix MEF ID diplay on person detailed view

Signed-off-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit merged commit 4fd768f into rero:master Oct 25, 2018
@iGormilhit iGormilhit deleted the translations-post-11 branch October 31, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants