patron: fix patron profile for dispute event #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
approved these changes
Oct 13, 2020
| <div class="col-lg-2 col-sm-1 label-title"> | ||
| <i class="fa fa-map-marker pr-1" title="{{ _('Library') }}"></i> | ||
| </div> | ||
| <div class="col-lg-10 col-sm-11"> {{ event.library.name }}</div> |
There was a problem hiding this comment.
make a class ml-1 and remove the space before value
benerken
approved these changes
Oct 13, 2020
zannkukai
force-pushed
the
zan-fix-dispute-patron-account
branch
2 times, most recently
from
4c5afde to
1317f61
Compare
When a patron has some fees containing at least one 'dispute' event, the server crash because ii tries to convert the amount of dispute (always none) to a decimal number. This PR fix this problem checking if the event to display has a valid 'amount' attribute. This PR also fixes some small HTML problems on the patron profile. Closes rero#1272 Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-fix-dispute-patron-account
branch
from
1317f61 to
176c502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a patron has some fees containing at least one 'dispute' event, the
server crash because ii tries to convert the amount of dispute (always
none) to a decimal number. This PR fix this problem checking if the
event to display has a valid 'amount' attribute. This PR also fixes some
small HTML problems on the patron profile.
Co-Authored-by: Renaud Michotte [email protected]
Why are you opening this PR?
Closes #1272
How to test?
Code review check list