check_license: accept Triple Slash Directive #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankoworld
requested review from
AoNoOokami and
rerowep
and removed request for
AoNoOokami
run-tests.sh checks that Licenses are OK for some files. This scripts fails when JS files use a Triple Slash Directive. This commit change this. * Improves check_license method to include Triple-Slash directives for .js files (Cf. https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html) * Avoids checking screenshots directory in Cypress * Adds a triple slash directive on 2 JS files (from Cypress). Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
doo-triple-dash-directives
branch
from
4584532 to
cf69684
Compare
zannkukai
approved these changes
Jul 20, 2020
lauren-d
approved these changes
Jul 20, 2020
Comment on lines
+453
to
+456
| is_js_file = file.name.split('.')[-1] == 'js' | ||
| if is_js_file and re.search(triple_slash, line): | ||
| return True | ||
| return False |
There was a problem hiding this comment.
cosmetic: can be replaced by:
if file.name.split('.')[-1] == 'js' and re.search(triple_slash, line):
return True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run-tests.sh checks that Licenses are OK for some files.
This scripts fails when JS files use a Triple Slash Directive.
This commit change this.
.js files (Cf.
https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html)
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
Because Cypress tests needs to be done on RERO ILS and I need to extend developer environment to do so.
How to test?
poetry run run-testsshouldn't give any error on Cypress JS files (that contains Triple Slash Directive)Code review check list