Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: sort alphabetically pickup location #1090

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

Garfield-fr
Copy link
Contributor

  • Sorts alphabetically the pickup locations as the patron place a request on an item.

Co-Authored-by: Bertrand Zuchuat [email protected]

Why are you opening this PR?

  • To add a sort on pickup name on request.

How to test?

  • Check order on menu

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

* Sorts alphabetically the pickup locations as the patron place a request on an item.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr requested a review from jma July 13, 2020 14:28
@iGormilhit iGormilhit added this to the v0.11.0 milestone Jul 14, 2020
@Garfield-fr Garfield-fr merged commit 7a8d502 into rero:dev Jul 20, 2020
@Garfield-fr Garfield-fr deleted the zub-pickup-sorted branch September 7, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants