Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circulation: trim barcode #789

Closed
pronguen opened this issue Feb 24, 2020 · 0 comments
Closed

Circulation: trim barcode #789

pronguen opened this issue Feb 24, 2020 · 0 comments
Assignees
@AoNoOokami
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface

Comments

@pronguen
Copy link
Contributor

Describe the issue
In circulation UI (checkin + checkout forms), I enter an item barcode with a space before or after (or both). The system does not recognise the item. (If I do the same with a patron number, it recognises the patron.)

To Reproduce

  1. Open checkin form
  2. Enter an item barcode with a space before or after or both

Expected behavior
It behaves as for patron numbers: the system trims the item barcode (in the checkin form AND in the checkout form).

Software version
ilsdev
rero-ils version 647a7f3
rero-ils-ui version 30e8cdd1
@AoNoOokami AoNoOokami self-assigned this Feb 24, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 24, 2020
circulation: fix some issues
d91a532 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami mentioned this issue Feb 24, 2020
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 24, 2020
circulation: fix some issues
0a5eee9 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 24, 2020
circulation: fix some issues
54043bf 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.

Co-Authored-by: Alicia Zangger <[email protected]>
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface labels Feb 24, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 24, 2020
circulation: fix some issues
ec8ad07 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: fix some issues
a82350a 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: fix some issues
3634357 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: fix some issues
830fbd4 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: fix some issues
c8b90d1 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Adds space between 'no loan' message an table.
* Removes outdated code.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.
* Closes rero/rero-ils#799.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: fix some minor issues
a2bfe21 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Adds space between 'no loan' message an table.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.
* Closes rero/rero-ils#799.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 26, 2020
circulation: fix some minor issues
8d5e5cc 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Adds space between 'no loan' message an table.
* Corrects destination display for in transit items.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.
* Closes rero/rero-ils#799.
* Closes rero/rero-ils#769.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 26, 2020
circulation: fix several issues
9303e49 
* Adds space between patron lastname and firstname.
* Trims barcode entererd in search input.
* Changes message when a checkout is done on an item that is already on loan.
* Displays action performed in checkin view.
* Adds space between 'no loan' message an table.
* Corrects destination display for in transit items.
* Closes rero/rero-ils#790.
* Closes rero/rero-ils#789.
* Closes rero/rero-ils#791.
* Closes rero/rero-ils#792.
* Closes rero/rero-ils#799.
* Closes rero/rero-ils#769.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 26, 2020
circulation: fix several issues
820d4b0 
* Adds space between patron lastname and firstname. Closes rero/rero-ils#790.
* Trims barcode entererd in search input. Closes rero/rero-ils#789.
* Changes message when a checkout is done on an item that is already on loan. Closes rero/rero-ils#791.
* Displays action performed in checkin view. Closes rero/rero-ils#792.
* Adds space between 'no loan' message an table. Closes rero/rero-ils#799.
* Corrects destination display for in transit items. Closes rero/rero-ils#769.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 26, 2020
circulation: fix several issues
b102977 
* Adds space between patron lastname and firstname. Closes rero/rero-ils#790.
* Trims barcode entererd in search input. Closes rero/rero-ils#789.
* Changes message when a checkout is done on an item that is already on loan. Closes rero/rero-ils#791.
* Displays action performed in checkin view. Closes rero/rero-ils#792.
* Adds space between 'no loan' message an table. Closes rero/rero-ils#799.
* Corrects destination display for in transit items. Closes rero/rero-ils#769.

Co-Authored-by: Alicia Zangger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @AoNoOokami