Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patron without barcode #48

Closed
pronguen opened this issue Jul 2, 2018 · 5 comments · Fixed by #140
Closed

Patron without barcode #48

pronguen opened this issue Jul 2, 2018 · 5 comments · Fixed by #140
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 2, 2018

When trying to display patron nr. 10 (Broglio, Giulia), we got an internal error server. To reproduce it, try to open https://ils.test.rero.ch/patrons/10.
It seems that this patron does not have any barcode, is this the cause of the problem? How is it possible that she has no barcode?

For information, this problem already appeared at previous deployment with patron Simonetta.

@iGormilhit
Copy link

iGormilhit commented Jul 2, 2018

@pronguen I've been able to edit this patron loading the http://localhost:5000/editor/update/ptrn/10 URL, and then to correct the missing barcode.

Still, I don't understand how this patron had no barcode after the populate.

For information, this problem already appeared at previous deployment with patron Simonetta.

It may be related to the deployment. Weird.

@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Jul 2, 2018
@iGormilhit
Copy link

On localhost, at the rero/reroils-data-legacy@6533d66, I have:
capture_120

@iGormilhit
Copy link

After a fresh deployment, all patrons have barcodes. I think that the removing of the barcode happens later, but I don't know how.

@pronguen
Copy link
Contributor Author

pronguen commented Jul 4, 2018

Sorry, I just destroyed again Giulia. What I did:

  • Looked for patrons
  • Selected Broglio, Giulia
  • Edited the patron
  • Deleted the barcode, but kept the patron role
  • Saved
  • Answer from the system: "The record has been saved (Utenti, pid: 10)." (Flash notification) + "Internal server error"

I managed to reintegrate this patron by using the "back" button of my web browser, and saving it again with the barcode.

Two problems then:

  • No validation before saving that there is a barcode
  • Saving is possible without barcode

@iGormilhit
Copy link

Ok, thanks, now we know for sure the problem. It's related to #37.

rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 9, 2018
* FIX: patron parcode missing
* closes rero#37
* closes rero#48

Signed-off-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 9, 2018
* FIX: patron parcode missing
* closes rero#37
* closes rero#48

Signed-off-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 9, 2018
* FIX: patron parcode missing
* closes rero#37
* closes rero#48

Signed-off-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 9, 2018
* FIX: patron parcode missing
* closes rero#37
* closes rero#48

Signed-off-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 9, 2018
* FIX: patron parcode missing
* closes rero#37
* closes rero#48

Signed-off-by: Peter Weber <[email protected]>
rerowep added a commit that referenced this issue Nov 12, 2018
* FIX: patron parcode missing
* closes #37
* closes #48

Signed-off-by: Peter Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants