Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Languages selector #349

Closed
iGormilhit opened this issue Jun 19, 2019 · 0 comments
Closed

[UI] Languages selector #349

iGormilhit opened this issue Jun 19, 2019 · 0 comments
Assignees
@Garfield-fr
Labels
translations Translations

Comments

@iGormilhit
Copy link

The languages selector shoudn't be translated, and each language name should always be in its own language: Deutsch, English, Français, Italiano.

The problem is that the same strings are used in the languages selector (config.py:92) and in the document editor (form_documents/document-v0.0.1.json:123).
@iGormilhit iGormilhit added translations Translations UI labels Jun 19, 2019
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 24, 2019
@Garfield-fr
ui: language menu
5346d95 
* Changes languages translation in menu selector.
* Closes rero#349

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Jun 24, 2019
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 27, 2019
@Garfield-fr
ui: language menu
316804b 
* Changes languages translation in menu selector.
* Closes rero#349

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 27, 2019
@Garfield-fr
ui: language menu
1a3dcc4 
* Changes languages translation in menu selector.
* Closes rero#349

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Jun 27, 2019
@Garfield-fr
ui: language menu
fc18cdc 
* Changes languages translation in menu selector.
* Closes #349

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
translations Translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Garfield-fr @iGormilhit