Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to enable/disable notification creation by config settings #2665

Closed
zannkukai opened this issue Jan 28, 2022 · 0 comments · Fixed by #2690
Closed

Allow to enable/disable notification creation by config settings #2665

zannkukai opened this issue Jan 28, 2022 · 0 comments · Fixed by #2690
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: notifications p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.9.0

Comments

@zannkukai
Copy link
Contributor

How it works

Currently, a notification is always created when notification creation is asked. In some specific case, it should be possible to disable some notification creation because an organisation would not sent this notification type.

Real example : At UCLouvain, we don't use "recall" notification. The current workaround is to not define any "library.notification_setting.request_email" metadata. If there is no email specification, the email isn't sent, but the notification resource is created into Invenio anyway.

Improvement suggestion

A configuration should be possible for each organisation to specify if a a notification type should be created or not ?
This settings should be part of the organisation settings because one organisation could use 'notification_type=A' but another organisation couldn't use this notification (in the same RERO-ILS installation ; Ex: recall for USL-B, not for UCLouvain)
@zannkukai zannkukai added enhancement Improvement of an existing feature f: notifications triage p-Medium Medium priority (to be solved within 1-2 years) labels Jan 28, 2022
@zannkukai zannkukai self-assigned this Feb 9, 2022
@zannkukai zannkukai added this to the v1.9.0 milestone Feb 9, 2022
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Feb 9, 2022
@zannkukai
notification: disable notifications creation by config
a2e8108 
Creates an new configuration variable allowing to disable some
notification creation based on notification type. Using this
configuration it's now possible to disable all 'recall' notification
creations by example.
Closes rero#2665.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Feb 9, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Feb 9, 2022
@zannkukai
notification: disable notifications creation by config
651e7e1 
Creates an new configuration variable allowing to disable some
notification creation based on notification type. Using this
configuration it's now possible to disable all 'recall' notification
creations by example.
Closes rero#2665.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Feb 9, 2022
@zannkukai
notification: disable notifications creation by config
84cef09 
Creates an new configuration variable allowing to disable some
notification creation based on notification type. Using this
configuration it's now possible to disable all 'recall' notification
creations by example.
Closes rero#2665.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue Feb 15, 2022
@zannkukai
notification: disable notifications creation by config
eea7aa9 
Creates an new configuration variable allowing to disable some
notification creation based on notification type. Using this
configuration it's now possible to disable all 'recall' notification
creations by example.
Closes #2665.

Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: notifications p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

notification: disable notifications creation by config zannkukai/rero-ils
1 participant
@zannkukai