Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification should be canceled if item is deleted #2410

Closed
rerowep opened this issue Sep 27, 2021 · 1 comment · Fixed by #2393
Closed

Notification should be canceled if item is deleted #2410

rerowep opened this issue Sep 27, 2021 · 1 comment · Fixed by #2393
Assignees
@zannkukai
Labels
f: notifications
Milestone
v1.6.0

Comments

@rerowep
Copy link
Contributor

rerowep commented Sep 27, 2021 •
edited by iGormilhit
Loading

A notification should be canceled if the associated item of the loan is deleted.
@iGormilhit
Copy link

@rerowep Is that an issue? I mean, did you encountered a specific case? If so, could you give context?

@iGormilhit iGormilhit linked a pull request Sep 30, 2021 that will close this issue
notifications: generalize notification resource #2393
Merged
7 tasks
@iGormilhit iGormilhit removed the triage label Sep 30, 2021
@iGormilhit iGormilhit added this to the v1.6.0 milestone Sep 30, 2021
@zannkukai zannkukai self-assigned this Oct 4, 2021
@zannkukai zannkukai mentioned this issue Oct 4, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 7, 2021
@zannkukai
notifications: generalize notification resource
93134a8 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 11, 2021
@zannkukai
notifications: generalize notification resource
4f45280 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 12, 2021
@zannkukai
notifications: generalize notification resource
8764996 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 12, 2021
@zannkukai
notifications: generalize notification resource
ecf3e13 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 12, 2021
@zannkukai
notifications: generalize notification resource
88e3922 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 13, 2021
@zannkukai
notifications: generalize notification resource
0481872 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue Oct 13, 2021
@zannkukai
notifications: generalize notification resource
f5bc227 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes #2373.
Closes #2390.
Closes #2410.

Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: notifications
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

notifications: generalize notification resource zannkukai/rero-ils
3 participants
@iGormilhit @zannkukai @rerowep