Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button 'login (to see request options)' has a wrong URL #1639

Closed
ManaDeweerdt opened this issue Jan 26, 2021 · 0 comments · Fixed by #1663
Closed

Button 'login (to see request options)' has a wrong URL #1639

ManaDeweerdt opened this issue Jan 26, 2021 · 0 comments · Fixed by #1663
Assignees
@rerowep
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface f: user management p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.0.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Jan 26, 2021 •
edited by iGormilhit
Loading

Describe the bug

As a guest on the public interface, when we try to login through the button 'login (to see request options') we are redirected to a 'page not found'.
It happens with the book.

To Reproduce

  1. Go to the public interface and search for a book. Ex: https://ilsdev.test.rero.ch/global/documents/1608913
  2. Click on the login button.
  3. See error

Expected behavior

The url is wrong. The space before '?next' must be deleted. Ex https://ilsdev.test.rero.ch/signin/%20%20?next=/global/documents/1608916.
@ManaDeweerdt ManaDeweerdt added triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Jan 26, 2021
@iGormilhit iGormilhit added f: public ui Public interface, as opposed to the professional interface f: user management and removed triage labels Jan 27, 2021
@iGormilhit iGormilhit added this to the v1.1.0 milestone Jan 28, 2021
rerowep added a commit to rerowep/rero-ils that referenced this issue Feb 2, 2021
@rerowep
ui: fix login button
3fa7d60 
* closes rero#1639

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep mentioned this issue Feb 2, 2021
Merged
7 tasks
rerowep added a commit to rerowep/rero-ils that referenced this issue Feb 2, 2021
@rerowep
public ui: fix login button on holdings section
3098fed 
* Closes rero#1639.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Feb 3, 2021
@rerowep
public ui: fix login button on holdings section
63425dc 
* Closes rero#1639.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Feb 3, 2021
@rerowep
public ui: fix login button on holdings section
8032e98 
* Closes rero#1639.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Feb 3, 2021
@rerowep
public ui: fix login button on holdings section
c549a21 
* Closes rero#1639.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit that referenced this issue Feb 3, 2021
@rerowep
public ui: fix login button on holdings section
271020b 
* Closes #1639.

Co-Authored-by: Peter Weber <[email protected]>
iGormilhit pushed a commit that referenced this issue Feb 4, 2021
@rerowep
public ui: fix login button on holdings section
e1d40b4 
* Closes #1639.

Co-Authored-by: Peter Weber <[email protected]>
@iGormilhit iGormilhit changed the title Button 'login (to see request options)' has a wrong url Button 'login (to see request options)' has a wrong URL Feb 8, 2021
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.0 Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface f: user management p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

public ui: fix login button on holdings section rerowep/rero-ils
3 participants
@iGormilhit @ManaDeweerdt @rerowep