Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date exceptions : repeat #155

Closed
NicolasLabat opened this issue Dec 11, 2018 · 1 comment
Closed

Date exceptions : repeat #155

NicolasLabat opened this issue Dec 11, 2018 · 1 comment
Labels
enhancement Improvement of an existing feature

Comments

@NicolasLabat
Copy link
Contributor

NicolasLabat commented Dec 11, 2018 •
edited
Loading

As an example, to add the 25.12.2018 as a closed day each year, the librarian has to activate the "Repeat" button and chose "Yearly" and then the value "1".
It's seems a bit confusing. The librarian can expect that the number "1" means the number of years the rule applies.
The display should be clearer. For example :
Repeat every [number] day(s)/week(s)/month(s)/year(s)
@NicolasLabat NicolasLabat added the enhancement Improvement of an existing feature label Dec 11, 2018
@pronguen
Copy link
Contributor

Simplify the UX based on:
image

Or just abandon the option to set the repetition frequence

@pronguen pronguen added this to the JR-2019 milestone Mar 18, 2019
@iGormilhit iGormilhit removed this from the JR-2019 milestone Mar 25, 2019
@iGormilhit iGormilhit added the UI label Mar 25, 2019
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
c9c74cd 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Apr 2, 2019
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
4d36393 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
f637dac 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
eec1105 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library exceptions date: improvement
2eb2c61 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library exceptions date: improvement
93357c1 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library exceptions date: improvement
a43ea98 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 8, 2019
@Garfield-fr
library exceptions date: improvement
b5c2fc4 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Apr 8, 2019
Merged
jma pushed a commit that referenced this issue Apr 8, 2019
@Garfield-fr @jma
library exceptions date: improvement
44360e4 
* BETTER Change the layout of the fields in the repeat area
* FIX closes #155 #223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
@jma jma closed this as completed in eeef882 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exception dates improvement Garfield-fr/rero-ils
3 participants
@iGormilhit @pronguen @NicolasLabat