Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authors and issuance fields: organisation as author and subtype are not loaded correctly when editing a record with those fields #1102

Closed
AoNoOokami opened this issue Jul 20, 2020 · 0 comments · Fixed by rero/ng-core#220
Closed

Authors and issuance fields: organisation as author and subtype are not loaded correctly when editing a record with those fields #1102

AoNoOokami opened this issue Jul 20, 2020 · 0 comments · Fixed by rero/ng-core#220
Assignees
@AoNoOokami
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Milestone
v0.11.0

Comments

@AoNoOokami
Copy link
Contributor

AoNoOokami commented Jul 20, 2020 •
edited by iGormilhit
Loading

Describe the bug
When editing a record, the mode of issuance is not loaded correctly and we lose data. It's the same behaviour for an organisation as author. This is related to the oneOf property in jsonschema and the way it's used in ngx-formly.

An issue has been reported on ngx-formly: ngx-formly/ngx-formly#2374

To Reproduce
Steps to reproduce the behavior:

  1. Go to a record that has an organisation as author
  2. Edit the record
  3. The author is a person and the name of the organisation is lost
  4. Similar behaviour is noted for 'mode of issuance' field with value different than default one

Expected behavior
The right data should be kept and displayed in the form.
@AoNoOokami AoNoOokami added f: editor Concerns editor based on JSON schema AND custom editor triage bug Breaks something but is not blocking labels Jul 20, 2020
@AoNoOokami AoNoOokami self-assigned this Jul 20, 2020
@AoNoOokami AoNoOokami changed the title Authors and issuance fields: organisation and subtype author are not loaded correctly when editing a record with those fields Authors and issuance fields: organisation as author and subtype are not loaded correctly when editing a record with those fields Jul 20, 2020
@AoNoOokami AoNoOokami removed the triage label Jul 20, 2020
@AoNoOokami AoNoOokami mentioned this issue Jul 20, 2020
Merged
7 tasks
@iGormilhit iGormilhit added this to the v0.11.0 milestone Jul 21, 2020
AoNoOokami pushed a commit to AoNoOokami/ng-core that referenced this issue Jul 21, 2020
project: update ngx-formly to v5.9.1
abbd35a 
* Updates ngx-formly to v5.9.1.
* Closes rero/rero-ils#1102.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami mentioned this issue Jul 21, 2020
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jul 21, 2020
editor: fix 'oneOf' data loading
2068f86 
* Fixes the loading of 'oneOf' data when editing a record.
* Closes rero#1102.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami mentioned this issue Jul 21, 2020
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/ng-core that referenced this issue Jul 21, 2020
project: update ngx-formly to v5.9.1
cabf938 
* Updates ngx-formly to v5.9.1.
* Closes rero/rero-ils#1102.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/ng-core that referenced this issue Jul 21, 2020
project: update ngx-formly to v5.9.1
ac89aed 
* Updates ngx-formly to v5.9.1.
* Adapts the code to allow an array of field keys (comes
ngx-formly/ngx-formly/commit/edf7f27).
* Closes rero/rero-ils#1102.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/ng-core that referenced this issue Jul 21, 2020
project: update ngx-formly to v5.9.1
3a552eb 
* Updates ngx-formly to v5.9.1.
* Adapts the code to allow an array of field keys (comes from
ngx-formly/ngx-formly/commit/edf7f27).
* Closes rero/rero-ils#1102.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit that referenced this issue Jul 21, 2020
@AoNoOokami
editor: fix 'oneOf' data loading
4ec4ab7 
* Fixes the loading of 'oneOf' data when editing a record.
* Closes #1102.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to rero/ng-core that referenced this issue Jul 21, 2020
@AoNoOokami
project: update ngx-formly to v5.9.1
bcbf2ea 
* Updates ngx-formly to v5.9.1.
* Adapts the code to allow an array of field keys (comes from
ngx-formly/ngx-formly/commit/edf7f27).
* Closes rero/rero-ils#1102.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit that referenced this issue Jul 21, 2020
editor: fix 'oneOf' data loading
c099f27 
* Fixes the loading of 'oneOf' data when editing a record.
* Closes #1102.

Co-Authored-by: Alicia Zangger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

project: update ngx-formly to v5.9.1 AoNoOokami/ng-core
2 participants
@iGormilhit @AoNoOokami