Skip to content

Commit

Permalink
modules: fix get_all_pids
Browse files Browse the repository at this point in the history
* Corrects `get_alll_pids` function limit offset search.

Co-Authored-by: Peter Weber <[email protected]>
  • Loading branch information
rerowep committed Dec 21, 2021
1 parent 9ead39c commit 9a29af2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion rero_ils/modules/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,10 @@ def get_all_pids(cls, with_deleted=False, limit=100000):
"""Get all records pids. Return a generator iterator."""
query = cls._get_all(with_deleted=with_deleted)
if limit:
count = query.count()
# slower, less memory
query = query.order_by(text('pid_value')).limit(limit)
offset = 0
count = cls.count(with_deleted=with_deleted)
while offset < count:
for identifier in query.offset(offset):
yield identifier.pid_value
Expand Down
2 changes: 1 addition & 1 deletion rero_ils/modules/monitoring/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@ def get_all_pids(cls, doc_type, with_deleted=False, limit=100000,
if date:
query = query.filter(PersistentIdentifier.created < date)
if limit:
count = query.count()
# slower, less memory
query = query.order_by(text('pid_value')).limit(limit)
offset = 0
count = query.count()
while offset < count:
for identifier in query.offset(offset):
yield identifier.pid_value
Expand Down

0 comments on commit 9a29af2

Please sign in to comment.