Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: clear input after checkout action #694

Merged
merged 1 commit into from
Sep 22, 2021
Merged

circulation: clear input after checkout action #694

merged 1 commit into from
Sep 22, 2021

Conversation

Garfield-fr
Copy link
Contributor

The input field is automatically disabled during
the transaction on the "checkin/checkout" and "Request" screens.

Co-Authored-by: Bertrand Zuchuat [email protected]

Dependencies

My PR depends on:

  • rero/ng-core (last dev)

How to test?

  • Check checkin/checkout and request screens.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management labels Aug 18, 2021
@Garfield-fr Garfield-fr self-assigned this Aug 18, 2021
@Garfield-fr Garfield-fr added this to the v1.5.0 milestone Aug 18, 2021
@Garfield-fr Garfield-fr force-pushed the zub-circulation-fix-2244 branch from 9bb27c4 to 530d97d Compare August 18, 2021 14:09
@pronguen
Copy link
Contributor

pronguen commented Aug 18, 2021 •
edited
Loading

  • In the following cases, the input is not cleared. It should always be.
    • item not found
      image
    • no action performed
      image
    • item already in the list
      image

@Garfield-fr Garfield-fr force-pushed the zub-circulation-fix-2244 branch 3 times, most recently from 7e714de to c6dcadb Compare August 19, 2021 06:07
iGormilhit
iGormilhit approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr
circulation: clear input after checkout action
3718935 
The input field is automatically disabled during
the transaction on the "checkin/checkout" and "Request" screens.

* Closes rero/rero-ils#2244.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr force-pushed the zub-circulation-fix-2244 branch from c6dcadb to 3718935 Compare September 16, 2021 08:06
@Garfield-fr Garfield-fr changed the base branch from dev to v0.16.14 September 21, 2021 08:29
@Garfield-fr Garfield-fr merged commit ec64798 into rero:v0.16.14 Sep 22, 2021
@Garfield-fr Garfield-fr deleted the zub-circulation-fix-2244 branch March 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@pronguen pronguen pronguen approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken Awaiting requested review from benerken

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@Garfield-fr Garfield-fr

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Sometimes the input field is not cleared in the 2 circulation forms.
4 participants
@Garfield-fr @pronguen @iGormilhit @zannkukai