documents: display 'part of' in brief views #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
added
f: professional ui
AoNoOokami
force-pushed
the
zaa-#1596-display-partof-brief-views
branch
2 times, most recently
from
430fb87 to
24baeff
Compare
AoNoOokami
force-pushed
the
zaa-#1596-display-partof-brief-views
branch
2 times, most recently
from
83ab3c4 to
92bbb2c
Compare
iGormilhit
reviewed
Feb 4, 2021
projects/shared/src/lib/view/brief/part-of/part-of.component.html
Outdated
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-#1596-display-partof-brief-views
branch
from
92bbb2c to
0d55509
Compare
iGormilhit
changed the title
iGormilhit
approved these changes
Feb 10, 2021
zannkukai
requested changes
Feb 16, 2021
projects/admin/src/app/record/brief-view/documents-brief-view/documents-brief-view.component.ts
Outdated
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-#1596-display-partof-brief-views
branch
from
0d55509 to
40c2f5f
Compare
zannkukai
requested changes
Feb 18, 2021
projects/shared/src/lib/view/brief/part-of/part-of.component.spec.ts
Outdated
Show resolved
Hide resolved
* Moves 'part of' template and code to a new component in shared library. This component is used in detailed and brief views. * Closes rero/rero-ils#1596. Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami
force-pushed
the
zaa-#1596-display-partof-brief-views
branch
from
40c2f5f to
2cb5959
Compare
zannkukai
approved these changes
Feb 22, 2021
lauren-d
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library. This component is used in detailed and brief views.
partOfon the brief views rero-ils#1596.Co-Authored-by: Alicia Zangger [email protected]
Why are you opening this PR?
To solve the issue mentioned above.
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):N/A
How to test?
See issue description.
Code review check list