Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: past participle used when action done #263

Merged
merged 1 commit into from
May 4, 2020

Conversation

zannkukai
Copy link
Contributor

Actions realised on item into checkin/checkout component are now display
in the past participle. This commit also updates button according UX
chart and the border around an operated item if special actions should
be done (fees|transit)

Co-authored-by: Renaud Michotte [email protected]

Why are you opening this PR?

Closes rero/rero-ils#890

How to test?

  • Do some checkin/checkout/renew operations for a patron.

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Apr 30, 2020
@zannkukai zannkukai force-pushed the zan-#update-circ-messages branch 2 times, most recently from 100dbb3 to a632b15 Compare April 30, 2020 13:29
@zannkukai zannkukai requested a review from iGormilhit April 30, 2020 13:43
@zannkukai zannkukai marked this pull request as ready for review April 30, 2020 13:43
Actions realised on item into checkin/checkout component are now display
in the past participle. This commit also updates button according UX
chart and the border around an operated item if special actions should
be done (fees|transit)

* Closes rero/rero-ils#890

Co-authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-#update-circ-messages branch from a632b15 to 01c685d Compare April 30, 2020 14:55
@zannkukai zannkukai merged commit 13b8ef2 into rero:dev May 4, 2020
@zannkukai zannkukai deleted the zan-#update-circ-messages branch May 5, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants