Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: improve filter configuration #383

Merged
merged 1 commit into from
May 12, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Apr 21, 2021

  • Replaces the button by a toggle on the filter display.
  • Adds URL parameters on searchFilter.
  • Updates the routing configuration to show all options.

Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Sébastien Délèze [email protected]

Why are you opening this PR?

  • Improve search filters to add some options

How to test?

  • Check configuration and test filters on Backend url

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@iGormilhit iGormilhit changed the title search filters: improve search: improve [what does it improve?] Apr 27, 2021
@iGormilhit iGormilhit added f: search f: professional ui Professional interface labels Apr 27, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Apr 27, 2021
@Garfield-fr Garfield-fr force-pushed the zub-search-filter-toggle branch 2 times, most recently from 84068ab to 67de715 Compare April 27, 2021 14:07
@Garfield-fr Garfield-fr changed the title search: improve [what does it improve?] search: improve filter configuration Apr 27, 2021
@Garfield-fr Garfield-fr marked this pull request as draft April 28, 2021 05:35
@Garfield-fr Garfield-fr force-pushed the zub-search-filter-toggle branch from 67de715 to b941ead Compare April 28, 2021 14:01
@Garfield-fr Garfield-fr marked this pull request as ready for review April 28, 2021 14:02
* Replaces the button by a toggle on the filter display.
* Adds URL parameters on searchFilter.
* Updates the routing configuration to show all options.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Sébastien Délèze <[email protected]>
@Garfield-fr Garfield-fr force-pushed the zub-search-filter-toggle branch from b941ead to c306cec Compare May 4, 2021 06:39
@jma jma removed their request for review May 4, 2021 11:53
@sebdeleze sebdeleze merged commit 3a3545e into rero:dev May 12, 2021
@Garfield-fr Garfield-fr deleted the zub-search-filter-toggle branch June 1, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: professional ui Professional interface f: search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants