Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: restrict template loading to resource creation. #332

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

zannkukai
Copy link
Contributor

To avoid parent reference problem, the 'load template' button should be
only displayed for resource creation (and hide when a resource is edited).

Closes rero/rero-ils#1471.

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Dec 15, 2020
@zannkukai zannkukai requested review from jma and sebdeleze December 15, 2020 10:08
@zannkukai zannkukai added this to the v1.0.0 milestone Dec 15, 2020
@iGormilhit iGormilhit added the f: editor Concerns editor based on JSON schema AND custom editor label Dec 16, 2020
@iGormilhit iGormilhit changed the title templates: restrict load template for resource creation. templates: restrict template loading to resource creation. Dec 16, 2020
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

templates: restrict to resource creation

To avoid parent reference issue, the 'load template' button should be
only displayed for resource creation (and hidden when a resource is
edited).

Closes rero/rero-ils#1471.

To avoid parent reference problem, the 'load template' button should be
only displayed for resource creation (and hide when a resource is edited).

Closes rero/rero-ils#1471.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the fix-template-behavior branch from b7e90bb to 2a9a054 Compare January 18, 2021 09:36
@zannkukai zannkukai merged commit 95be0e2 into rero:dev Jan 18, 2021
@zannkukai zannkukai deleted the fix-template-behavior branch January 18, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot save a prediction pattern for an existing holding
4 participants