-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.8 & 3.9 as supported versions #442
Conversation
This will fix #443. How about adding Python 3.9 as well, and testing both 3.8 and 3.9 on the CI too? |
@hugovk Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could someone from this organisation enable/transfer Travis CI from .org to .com?
@jtroussard any chance you can get this merged with the impending python EOL |
Which impending EOL? Python 3.10 is due out today, we could also add 3.10 too :) (Would need to be |
tbh that can be done in a follow-up PR too, we shouldn't need to wait for it. |
I was referring 3.6 in December 2021. |
@JonathanHuot would you be able to take a peek on these conflicts? I believe this PR should be an easy review/merge. Correct me if I am wrong but we have agreed to move away from travisCI? If so we can remove that file from this PR. |
b07d216
to
75b6137
Compare
Since Py 3.8 & 3.9 is supported, we should update the identified, as it is shown on PIP and gives wrong impressions that Py 3.8 is not supported
I have rebased and fixed conflicts, hopefully this time around this will be merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Since Py 3.8 is supported, we should update the "classifiers", as it is shown on PyPI and gives wrong impressions that Py 3.8 is not supported.
This PR also adds Py 3.9 and adds them to CI