Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.8 & 3.9 as supported versions #442

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

kaxil
Copy link
Contributor

@kaxil kaxil commented Apr 20, 2021

Since Py 3.8 is supported, we should update the "classifiers", as it is shown on PyPI and gives wrong impressions that Py 3.8 is not supported.

This PR also adds Py 3.9 and adds them to CI

@coveralls
Copy link

coveralls commented Apr 20, 2021

Coverage Status

Coverage remained the same at 90.239% when pulling 881d834 on kaxil:patch-1 into fb3ec4e on requests:master.

@hugovk
Copy link
Contributor

hugovk commented Apr 30, 2021

This will fix #443.

How about adding Python 3.9 as well, and testing both 3.8 and 3.9 on the CI too?

@hugovk hugovk mentioned this pull request Apr 30, 2021
1 task
@kaxil
Copy link
Contributor Author

kaxil commented Sep 20, 2021

@hugovk Done

@kaxil kaxil changed the title Add Python 3.8 as supported version Add Python 3.8 & 3.9 as supported versions Sep 20, 2021
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could someone from this organisation enable/transfer Travis CI from .org to .com?

@jsadn
Copy link

jsadn commented Oct 4, 2021

@jtroussard any chance you can get this merged with the impending python EOL

@hugovk
Copy link
Contributor

hugovk commented Oct 4, 2021

Which impending EOL?

Python 3.10 is due out today, we could also add 3.10 too :) (Would need to be 3.10-dev on Travis CI until they add the 3.10.0 release in a few weeks' time.)

https://twitter.com/pyblogsal/status/1442890650303664131

@kaxil
Copy link
Contributor Author

kaxil commented Oct 4, 2021

Which impending EOL?

Python 3.10 is due out today, we could also add 3.10 too :) (Would need to be 3.10-dev on Travis CI until they add the 3.10.0 release in a few weeks' time.)

https://twitter.com/pyblogsal/status/1442890650303664131

tbh that can be done in a follow-up PR too, we shouldn't need to wait for it.

@jsadn
Copy link

jsadn commented Oct 4, 2021

Which impending EOL?

I was referring 3.6 in December 2021.
3.7 is on the supported list I suppose, but I'd love to use this lib with confidence for py 3.8.

@JonathanHuot JonathanHuot added this to the 1.3.1 milestone Nov 2, 2021
@jtroussard
Copy link
Contributor

@JonathanHuot would you be able to take a peek on these conflicts? I believe this PR should be an easy review/merge. Correct me if I am wrong but we have agreed to move away from travisCI? If so we can remove that file from this PR.

@kaxil kaxil force-pushed the patch-1 branch 2 times, most recently from b07d216 to 75b6137 Compare December 30, 2021 22:55
Since Py 3.8 & 3.9 is supported, we should update the identified, as it is shown on PIP and gives wrong impressions that Py 3.8 is not supported
@kaxil
Copy link
Contributor Author

kaxil commented Dec 30, 2021

@JonathanHuot would you be able to take a peek on these conflicts? I believe this PR should be an easy review/merge. Correct me if I am wrong but we have agreed to move away from travisCI? If so we can remove that file from this PR.

I have rebased and fixed conflicts, hopefully this time around this will be merged :)

Copy link
Contributor

@jtroussard jtroussard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants