Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Output API documentation _outputHelper to _reqnrollOutputHelper in constructor #412

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Sjors-Hoogenboom
Copy link
Contributor

@Sjors-Hoogenboom Sjors-Hoogenboom commented Jan 23, 2025

🤔 What's changed?

I changed the documentation output API constructor to contain _reqnrollOutputHelper instead of _outputHelper

⚡️ What's your motivation?

I noticed this small error while reading the documentation

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

♻️ Anything particular you want feedback on?

Not sure if refacotring the field to _outputHelper would've been more appriciated than changing the constructor

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@Sjors-Hoogenboom Sjors-Hoogenboom changed the title Changed _outputHelper to _reqnrollOutputHelper in constructor Changed Output API documentation _outputHelper to _reqnrollOutputHelper in constructor Jan 23, 2025
@ajeckmans ajeckmans merged commit 810100b into reqnroll:main Jan 23, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants