Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading plugin dependencies from .deps.json on .NET Framework and Visual Studio MSBuild #411

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

  • When loading plugins, we also look for .deps.json and use the content to load dependencies (of the plugin).
  • Added documentation for PlugIn Writer
  • Added regression tests for NUnit Retry (which uses .deps.json)

⚡️ What's your motivation?

Fixes #410 and standardises the behaviour of .NET 6+ and the .NET Framework.
NET 6+ already uses `DependencyContext', with this PR the .NET Framework does as well.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

We could also use this approach to reduce the size of Reqnroll.Tools.MsBuild.Generation. But that should be part of another PR.

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I refactored the resolvers a bit, but this is fine.

@gasparnagy gasparnagy merged commit 182e933 into main Feb 5, 2025
5 checks passed
@gasparnagy gasparnagy deleted the depsjson branch February 5, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reqnroll.VisualStudio plugin causes build to fail if the NUnitRetry.ReqnrollPlugin is used
3 participants