support GitHub Action #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okkez
reviewed
Aug 2, 2023
Comment on lines
+28
to
+32
| if [ "${VERSION}" = "latest" ]; then | ||
| DOWNLOAD_URL=$(curl "${api_request_args[@]}" https://api.github.com/repos/reproio/terraform-j2md/releases | jq -r '[.[] | select(.prerelease==false)][0].assets[].browser_download_url | select(match("Linux_x86_64"))') | ||
| else | ||
| DOWNLOAD_URL=https://github.com/reproio/terraform-j2md/releases/download/${VERSION}/terraform-j2md_Linux_x86_64.tar.gz | ||
| fi |
There was a problem hiding this comment.
How about calculating archive name from combo of RUNNER_OS and RUNNER_ARCH?
https://docs.github.com/en/enterprise-cloud@latest/actions/learn-github-actions/variables
There was a problem hiding this comment.
I think this action used by OS and ARCH except Linux and x86_64 is a rare case. If anyone wants to support other OS or Arch, I'll improve at time.
akihiro17
reviewed
Aug 3, 2023
action.yml
Outdated
| mkdir -p ${RUNNER_TOOL_CACHE}/terraform-j2md | ||
| cd /tmp | ||
| curl -sfLO ${DOWNLOAD_URL} | ||
| tar xzvf $(basename $DOWNLOAD_URL .tar.gz).tar.gz |
There was a problem hiding this comment.
[IMO] curl -sfL ${DOWNLOAD_URL} | tar xvf -みたいにすると標準入力から受け取れるのでファイル名指定しなくて良くなると思います
README.md
Outdated
| ```yaml | ||
| - uses: reproio/terraform-j2md@main | ||
| with: | ||
| version: v0.0.5 # or latest |
There was a problem hiding this comment.
[nits] 現状の最新v0.0.7の方が良いんじゃないかと思いました。
action.yml
Outdated
| cd /tmp | ||
| curl -sfLO ${DOWNLOAD_URL} | ||
| tar xzvf $(basename $DOWNLOAD_URL .tar.gz).tar.gz | ||
| sudo install terraform-j2md ${RUNNER_TOOL_CACHE}/terraform-j2md/terraform-j2md |
There was a problem hiding this comment.
[IMO] installコマンド使っているなら
mkdir -p ${RUNNER_TOOL_CACHE}/terraform-j2mdを消して
sudo install -D terraform-j2md ${RUNNER_TOOL_CACHE}/terraform-j2md/terraform-j2mdとできるんじゃないかと思いました。
okkez
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to use terraform-j2md from GitHub Action.