Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2252] Update ubuntu runner #18

Merged
merged 4 commits into from
Feb 10, 2025
Merged

[#2252] Update ubuntu runner #18

merged 4 commits into from
Feb 10, 2025

Conversation

JoanneHing
Copy link
Contributor

@JoanneHing JoanneHing commented Feb 8, 2025

Part of #2252 in Reposense Repository

Proposed commit message

Update ubuntu runner to ubuntu-24.04

This PR updates the CI configuration to ubuntu 24.04 as the runner.
This ensures that our code is tested on the latest Ubuntu version,
providing better compatibility and early detection of potential issues. 

@JoanneHing JoanneHing requested a review from gok99 February 8, 2025 08:55
@gok99
Copy link
Contributor

gok99 commented Feb 8, 2025

Thanks @JoanneHing! I realized we don't have checks that run on PRs in publish-RepoSense. Let's get the CI running for PRs to make sure this works before merging it.

Could you create a separate PR to have Install dependencies and Generate report run on PRs from all branches, but all tasks including Deploy GitHub pages should run on pushes to master. You could do this by creating a separate ci script (more things to manage) or splitting the job in the current one.

@JoanneHing
Copy link
Contributor Author

Thanks @JoanneHing! I realized we don't have checks that run on PRs in publish-RepoSense. Let's get the CI running for PRs to make sure this works before merging it.

Could you create a separate PR to have Install dependencies and Generate report run on PRs from all branches, but all tasks including Deploy GitHub pages should run on pushes to master. You could do this by creating a separate ci script (more things to manage) or splitting the job in the current one.

Alright sure I can work on that!

@gok99
Copy link
Contributor

gok99 commented Feb 9, 2025

@JoanneHing please merge resolve conflicts with master

@JoanneHing
Copy link
Contributor Author

JoanneHing commented Feb 9, 2025

@JoanneHing please merge resolve conflicts with master

Fixed! Some checks are failing let me check how to resolve it.

@gok99
Copy link
Contributor

gok99 commented Feb 9, 2025

This issue might be helpful

@JoanneHing
Copy link
Contributor Author

This issue might be helpful

Correct me if I am wrong, based on my understanding the current test with ubuntu-24.04 is failing because it uses Java 17 by default, but it is not fully supported on the published version of reposense. Based on the resource provided by YiXun, we might need to update registerTypeAdapter to registerTypeHierarchyAdapter for LocalDateTime and ZoneId in related files to resolve the issue. So should we update the runner to ubuntu-24.04 after the published file is updated or find some other ways to resolve the issue?

@gok99
Copy link
Contributor

gok99 commented Feb 9, 2025

Yes the github 24.04 runner runs Java 17 by default. We should specifically use Java 11 in publish-RepoSense, until we officially bump support.

@JoanneHing
Copy link
Contributor Author

Yes the github 24.04 runner runs Java 17 by default. We should specifically use Java 11 in publish-RepoSense, until we officially bump support.

Alright I can update that!

Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@gok99 gok99 merged commit 07e8d6e into reposense:master Feb 10, 2025
1 check passed
@JoanneHing JoanneHing self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants