-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2252] Update ubuntu runner #18
Conversation
Thanks @JoanneHing! I realized we don't have checks that run on PRs in publish-RepoSense. Let's get the CI running for PRs to make sure this works before merging it. Could you create a separate PR to have |
Alright sure I can work on that! |
@JoanneHing please merge resolve conflicts with master |
Fixed! Some checks are failing let me check how to resolve it. |
This issue might be helpful |
Correct me if I am wrong, based on my understanding the current test with ubuntu-24.04 is failing because it uses Java 17 by default, but it is not fully supported on the published version of reposense. Based on the resource provided by YiXun, we might need to update |
Yes the github 24.04 runner runs Java 17 by default. We should specifically use Java 11 in publish-RepoSense, until we officially bump support. |
Alright I can update that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing this!
Part of #2252 in Reposense Repository
Proposed commit message