Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configuration files to match latest version #11

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Update configuration files to match latest version #11

merged 4 commits into from
Dec 15, 2022

Conversation

RyanCheungJF
Copy link
Contributor

@RyanCheungJF RyanCheungJF commented Dec 8, 2022 •
edited by dcshzj
Loading

Resolves #1768.

Based changes off the latest commit on the author-config.csv in the main repo as shown here. Mainly, two fields are changed.

Currently, there is a warning due to the outdated header fields in both 
the author-config and repo-config CSV files.

Let's update both CSV files so that the headers are now synchronized
with what is supported in the latest version of RepoSense.

@dcshzj
Copy link
Member

dcshzj commented Dec 14, 2022

Hey! Thanks for the PR! Are you also able to update the repo-config.csv file as well? There are a few new columns that were added over time but the file in this repository was not updated.

@dcshzj dcshzj self-requested a review December 14, 2022 01:49
@RyanCheungJF
Copy link
Contributor Author

Sure @dcshzj , I've updated my PR to update the other config file. Do let me know if you need anything else updated. Thanks in advance.

dcshzj
dcshzj requested changes Dec 15, 2022
View reviewed changes
configs/repo-config.csv Outdated
@@ -1,2 +1,2 @@
Repository's Location,Branch,File formats,Ignore Glob List,Ignore standalone config,Ignore Commits List,Ignore Authors List
https://github.com/reposense/RepoSense.git,master,,,,,
Repository's Location,Branch,File formats,Ignore Glob List,Ignore standalone config,Ignore Commits List,Ignore Authors List,Shallow Cloning,Find Previous Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a number of columns are still missing, do refer to the documentation on the full list of columns that should be present:

  1. File Size Limit
  2. Ignore File Size Limit
  3. Skip Ignored File Analysis

If possible, do also follow the order that is presented in the user guide so it is easier for our users to follow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad, I was following the config file in the reposense repo. I've updated and ordered them according the the docs. Let me know if you need any more changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanCheungJF The newline needs to be added as well, currently the repo-config.csv file is missing a final newline.

dcshzj
dcshzj approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@dcshzj dcshzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcshzj dcshzj changed the title Update author config csv Update configuration files to match latest version Dec 15, 2022
@dcshzj dcshzj merged commit 75d21e3 into reposense:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

publish-reposense's author-config.csv is out of date
2 participants
@RyanCheungJF @dcshzj