Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#944] Implement authorship analysis #949

Closed
wants to merge 4 commits into from

Conversation

myteo
Copy link
Contributor

@myteo myteo commented Nov 21, 2019

Fixes #944.

A line is credited to the author who last modified it.

Another author might have written the line initially and the current
author only modified it slightly. In such a case, the current author
gets credited for work that is not entirely done by them.

Lets analyze how similar a line is to its ancestor line (previous
version of the line) and give partial or full credit to the author
based on the analysis. This feature is turned off by default as
it takes quite long to run.

@myteo myteo force-pushed the 944-analyze-authorship branch from 4467c77 to c44839d Compare November 21, 2019 07:47
@myteo myteo force-pushed the 944-analyze-authorship branch from 4d5b38a to b5abc13 Compare November 21, 2019 14:37
@myteo myteo marked this pull request as ready for review November 21, 2019 18:55
@myteo myteo requested review from a team November 21, 2019 19:27
@myteo
Copy link
Contributor Author

myteo commented Nov 21, 2019

Please let me know if you need any clarifications as this is quite a big PR 😬

@eugenepeh
Copy link
Member

Please let me know if you need any clarifications as this is quite a big PR 😬

Indeed a big PR that is few hundred lines long. Can you give a brief technical implementation summary on the concept? If possible, would be preferable if it can break down to few smaller PRs.

@myteo
Copy link
Contributor Author

myteo commented Dec 3, 2019

Indeed a big PR that is few hundred lines long. Can you give a brief technical implementation summary on the concept?

I have added some descriptions in the issue (#944). Please let me know if any further clarification is needed.

If possible, would be preferable if it can break down to few smaller PRs.

I will create a feature branch and create a smaller PRs towards the feature branch. Is that ok?

@eugenepeh
Copy link
Member

I will create a feature branch and create a smaller PRs towards the feature branch. Is that ok?

Sorry for late reply, yes that would be preferred.

@fzdy1914
Copy link
Member

Just a question, shouldn't the PR targets to a feature branch? not master?

@myteo
Copy link
Contributor Author

myteo commented Jan 26, 2020

Just a question, shouldn't the PR targets to a feature branch? not master?

Yes it should be feature branch. I am still working on splitting up the PR, will try to get that out when I have more time.

@fzdy1914 fzdy1914 removed request for a team February 27, 2020 12:34
@fzdy1914
Copy link
Member

Closing this PR because it has been inactive for a very long time. For the contributors who are willing to take over, you may just use the code here as a start point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code authorship attribution
3 participants