Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2273] Update workflows to use v4 of artifact actions #2274

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[#2273] Update workflows to use v4 of artifact actions #2274

merged 1 commit into from
Jan 31, 2025

Conversation

Airiinnn
Copy link
Contributor

@Airiinnn Airiinnn commented Jan 31, 2025 •
edited
Loading

Fixes #2273

Proposed commit message

Upgrade artifact actions to v4

All workflows using v3 of artifact actions automatically fail from
2025-01-30 onwards due to deprecation.

Let's upgrade to the latest version (v4).

Other information

@Airiinnn Airiinnn force-pushed the 2273-bump-up-actions-upload-artifact-version branch 8 times, most recently from 9638059 to 547982a Compare January 31, 2025 16:52
@Airiinnn Airiinnn closed this Jan 31, 2025
@Airiinnn Airiinnn reopened this Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

@Airiinnn Airiinnn force-pushed the 2273-bump-up-actions-upload-artifact-version branch from 547982a to 635ee39 Compare January 31, 2025 17:07
@Airiinnn Airiinnn force-pushed the 2273-bump-up-actions-upload-artifact-version branch from 635ee39 to 91a3387 Compare January 31, 2025 17:08
@Airiinnn
Copy link
Contributor Author

Airiinnn commented Jan 31, 2025 •
edited
Loading

Due to how the pull_request_target trigger runs in the context of the base of the pull request, rather than in the context of the merge commit, getting the failing check (.github/workflows/pending.yml) to pass is not possible within PRs (to my knowledge).

This problem is only possible because previously passing checks auto-fail after 2025-01-30 due to the deprecation. Can we make an exception to merge this in?

Future runs of the workflow should pass after merging this in as the base of the PRs for those runs would have the updated pending.yml workflow.

References:

@Airiinnn Airiinnn marked this pull request as ready for review January 31, 2025 17:43
@Airiinnn Airiinnn requested review from a team January 31, 2025 17:44
ckcherry23
ckcherry23 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the lead on fixing this!

sopa301
sopa301 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not exactly sure if the artifact naming needs to be changed but it's easier to diagnose after merging this.

Since this is urgent, let's skip the usual 2-day waiting period.

@sopa301 sopa301 merged commit b70bf5e into reposense:master Jan 31, 2025
8 of 9 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

@ckcherry23
Copy link
Member

I'm not exactly sure if the artifact naming needs to be changed but it's easier to diagnose after merging this.

Yes, let's keep the PRs well-scoped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failing due to deprecation of actions/upload-artifact@v3
3 participants
@Airiinnn @ckcherry23 @sopa301