Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2262] Update type adapter adding methods for gson builder #2270

Merged
merged 11 commits into from
Feb 5, 2025
Merged

[#2262] Update type adapter adding methods for gson builder #2270

merged 11 commits into from
Feb 5, 2025

Conversation

CYX22222003
Copy link
Contributor

@CYX22222003 CYX22222003 commented Jan 29, 2025 •
edited
Loading

Fixes #2262

Proposed commit message

Update GSON type adapter adding methods

The registration of custom adapters for ZoneID and LocalDateTime causes
The JsonIOException to pop up when trying to run the jar file in java
17.

Let's use the registerTypeHierarchyAdapter method to add the custom
adapters instead.

Other information

Here are some reference resources I found online:

@CYX22222003 CYX22222003 self-assigned this Jan 29, 2025
@CYX22222003 CYX22222003 requested review from a team January 29, 2025 03:27
@lyuanww lyuanww mentioned this pull request Jan 31, 2025
Merged
@CYX22222003 CYX22222003 changed the title Update gson builder type adapter adding method [#2262] Update type adapter adding methods for gson builder Feb 1, 2025
@CYX22222003 CYX22222003 marked this pull request as draft February 1, 2025 07:52
@CYX22222003 CYX22222003 removed the request for review from a team February 1, 2025 07:52
@CYX22222003 CYX22222003 removed their assignment Feb 1, 2025
@CYX22222003 CYX22222003 marked this pull request as ready for review February 1, 2025 16:11
lyuanww
lyuanww reviewed Feb 2, 2025
View reviewed changes
Copy link
Contributor

@lyuanww lyuanww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! It works with both Java 17 and Java 11 on my machine. I just have some small suggestions.

CYX22222003 and others added 2 commits February 3, 2025 07:55
@CYX22222003
Update FileUtil and DateSerializer
07e46e3 
Move declaration of date format and
remove unnecessary blank lines.
@CYX22222003
Merge branch 'master' into gson-adapter
5081b53
@CYX22222003 CYX22222003 requested a review from a team February 3, 2025 06:53
@sopa301 sopa301 requested a review from lyuanww February 3, 2025 16:26
@CYX22222003 CYX22222003 removed the request for review from a team February 3, 2025 23:34
lyuanww
lyuanww approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@lyuanww lyuanww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CYX22222003 CYX22222003 requested a review from a team February 4, 2025 06:30
sopa301
sopa301 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some very minor nitpicks.

src/main/java/reposense/util/FileUtil.java Show resolved Hide resolved
src/main/java/reposense/util/FileUtil.java Outdated Show resolved Hide resolved
@sopa301 sopa301 merged commit 143af1c into reposense:master Feb 5, 2025
11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@lyuanww lyuanww lyuanww approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old dashboards failing due to com.google.gson.JsonIOException
3 participants
@CYX22222003 @sopa301 @lyuanww