Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2259] Upgrade GitHub Actions macOS runners to 13, 14 and 15 #2260

Merged
merged 10 commits into from
Jan 27, 2025
Merged

[#2259] Upgrade GitHub Actions macOS runners to 13, 14 and 15 #2260

merged 10 commits into from
Jan 27, 2025

Conversation

JoanneHing
Copy link
Contributor

@JoanneHing JoanneHing commented Jan 19, 2025 •
edited
Loading

Fixes #2259

Proposed commit message

Update GitHub Action runner to macOS 13, 14, 15 and remove macOS 12

The macOS 12 version is deprecated and removed by the end of 2024.
This commit updates the GitHub Action runner to use macOS 13, 14,
and 15 instead.

@JoanneHing JoanneHing changed the title Fixes #2259 [#2259] Upgrade GitHub Actions macOS runners to 13, 14 and 15 Jan 19, 2025
@JoanneHing JoanneHing self-assigned this Jan 19, 2025
joeng03
joeng03 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@joeng03 joeng03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All CI passed.

ckcherry23
ckcherry23 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ckcherry23
Copy link
Member

Updated the CI status check requirements from macos-12 to macos-13, macos-14, macos-15. All PRs must be rebased after this is merged to pass the status checks 👍🏼

@gok99
Copy link
Contributor

gok99 commented Jan 24, 2025

Could you also bump the macos used for the Codecov task? (I just noticed it was still using macos-11)

ckcherry23
ckcherry23 reviewed Jan 25, 2025
View reviewed changes
.github/workflows/integration.yml Outdated
@@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
# Deprecation Notice: MacOS 12 will be deprecated by the end of 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comment now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! I will update on this!

@JoanneHing
Copy link
Contributor Author

Could you also bump the macos used for the Codecov task? (I just noticed it was still using macos-11)

Alright I update the macOS to 15 for the Codecov Task.

@jonasongg
Copy link
Contributor

We might want to add the reposense-logs folder to .gitignore, but for now maybe we should remove that log file from the PR?

sikai00
sikai00 requested changes Jan 26, 2025
View reviewed changes
reposense-logs/reposense.log.0 Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I didn't notice the reposense-logs generated is not included in the .gitignore! I will update on this!

@sikai00
Copy link
Member

sikai00 commented Jan 26, 2025

@JoanneHing can you try adding a line to update the apt indexes as mentioned here: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/customizing-github-hosted-runners#installing-software-on-ubuntu-runners

Otherwise it could be an outage on the dependency's repository and we might have to try again later on

@JoanneHing
Copy link
Contributor Author

@JoanneHing can you try adding a line to update the apt indexes as mentioned here: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/customizing-github-hosted-runners#installing-software-on-ubuntu-runners

Otherwise it could be an outage on the dependency's repository and we might have to try again later on

Alright let me try fixing on that!

@JoanneHing
Copy link
Contributor Author

@JoanneHing can you try adding a line to update the apt indexes as mentioned here: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/customizing-github-hosted-runners#installing-software-on-ubuntu-runners

Otherwise it could be an outage on the dependency's repository and we might have to try again later on

Update on this, the issue of the environment set up is fix now

@JoanneHing JoanneHing requested a review from sikai00 January 27, 2025 04:50
@JoanneHing
Copy link
Contributor Author

Note that the runner for Cypress Frontend test is updated to ubuntu-24.04 in order to fix the environment set up issue.

@sopa301 sopa301 removed the request for review from sikai00 January 27, 2025 05:16
sopa301
sopa301 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sopa301
Copy link
Contributor

sopa301 commented Jan 27, 2025

Will skip the usual 2-day waiting period as this is urgent.

@sopa301 sopa301 merged commit 7eb104c into reposense:master Jan 27, 2025
9 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@joeng03 joeng03 joeng03 approved these changes

@sikai00 sikai00 sikai00 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees

@JoanneHing JoanneHing

Labels
p.Urgent s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade GitHub Actions macOS runners to 13 and 14 (and possibly 15)
7 participants
@JoanneHing @ckcherry23 @gok99 @jonasongg @sikai00 @sopa301 @joeng03