Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.sh: provide a flag to indicate major version #2208

Closed
damithc opened this issue May 16, 2024 · 5 comments · Fixed by reposense/publish-RepoSense#12
Closed

run.sh: provide a flag to indicate major version #2208

damithc opened this issue May 16, 2024 · 5 comments · Fixed by reposense/publish-RepoSense#12

Comments

@damithc
Copy link
Collaborator

damithc commented May 16, 2024

Context: see https://reposense.org/ug/runSh.html

Suggested: provide a way to specify that the latest release of a specific major version should be used.
For example --version 3.* will use the latest version that starts with 3.

Justification: This way, the user can take advantage of latest bug fixes while avoiding breaking changes (assuming breaking changes will only be introduced in new major versions)

@jedkohjk
Copy link
Contributor

Hi, I'm interested in taking this issue, but it appears that it will require changes to the publish-RepoSense repo? Should we make a PR to that repo?

@ckcherry23
Copy link
Member

@jedkohjk Yes, you can make a PR to the publish-RepoSense repository.

@jedkohjk
Copy link
Contributor

jedkohjk commented Jul 3, 2024

Hi, is it okay to do this as an extension of the --tag flag instead of adding a new --version flag? That is, allowing --tag to take in an expression with the wildcard *, then picking the latest version that fits that expression.

@gok99
Copy link
Contributor

gok99 commented Jul 3, 2024

Hi @jedkohjk, sounds good to me. This'd be a natural extension of the --tag flag.

@jedkohjk
Copy link
Contributor

jedkohjk commented Jul 6, 2024

Hi, I made a PR related to this 3 days ago. Can anyone review it? Thank you!

@github-project-automation github-project-automation bot moved this to Closed/Completed in RepoSense Roadmap Aug 1, 2024
gok99 pushed a commit that referenced this issue Aug 13, 2024
…se (#2244)

The user guide section for `run.sh` requires updating after the PR to publish-RepoSense: reposense/publish-RepoSense#12

Let's update the User Guide to describe `--latest` tag in the `run.sh` section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Completed
Development

Successfully merging a pull request may close this issue.

4 participants