Split SMTP creation and deletion notifications logic #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raikbitters
commented
Dec 6, 2024
•
raikbitters
commented
- Separated the logic for creating and deleting SMTP notifications
- Refactored code for better readability and maintainability
- Separated the logic for creating and deleting SMTP notifications - Updated relevant tests to reflect the changes - Refactored code for better readability and maintainability
grabsefx
previously approved these changes
Dec 6, 2024
grabsefx
approved these changes
Dec 6, 2024
APiankouski
approved these changes
Dec 6, 2024
raikbitters
deleted the
feature/split-smtp-creation-and-deletion-notifications
branch
raikbitters
restored the
feature/split-smtp-creation-and-deletion-notifications
branch
raikbitters
deleted the
feature/split-smtp-creation-and-deletion-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.