-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-97471 || Added old representation of date in launch and item #2109
Conversation
@Test | ||
void getLaunchUuidPositiveTimestamp() throws Exception { | ||
mockMvc.perform( | ||
get(DEFAULT_PROJECT_BASE_URL + "/launch/uuid/4850a659-ac26-4a65-8ea4-a6756a57fb92").with( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 101).
@Test | ||
void getLaunchUuidPositive() throws Exception { | ||
mockMvc.perform( | ||
get(DEFAULT_PROJECT_BASE_URL + "/launch/uuid/4850a659-ac26-4a65-8ea4-a6756a57fb92").with( | ||
token(oAuthHelper.getDefaultToken()))).andExpect(status().is(200)); | ||
get(DEFAULT_PROJECT_BASE_URL + "/launch/uuid/4850a659-ac26-4a65-8ea4-a6756a57fb92").with( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 101).
@@ -92,6 +93,33 @@ private TestItemConverter() { | |||
return resource; | |||
}; | |||
|
|||
public static final Function<TestItemResource, TestItemResourceOld> TO_RESOURCE_TIMESTAMP = item -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 103).
@@ -97,6 +98,30 @@ public class LaunchConverter { | |||
return resource; | |||
}; | |||
|
|||
public Function<LaunchResource, LaunchResourceOld> TO_RESOURCE_OLD = resource -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'TO_RESOURCE_OLD' must contain no more than '1' consecutive capital letters.
@@ -97,6 +98,30 @@ public class LaunchConverter { | |||
return resource; | |||
}; | |||
|
|||
public Function<LaunchResource, LaunchResourceOld> TO_RESOURCE_OLD = resource -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member name 'TO_RESOURCE_OLD' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
description = "Successful response with dates in timestamp format. " | ||
+ "Response with dates in ISO-8601 format if the custom header " | ||
+ "'Accept: application/x.reportportal.launch.v2+json' is used.", | ||
content = @Content(mediaType = "application/json", schema = @Schema(implementation = LaunchResourceOld.class)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 116).
) | ||
public LaunchResourceOld mergeLaunchesOldUuid(@PathVariable String projectName, | ||
@Parameter(description = "Merge launches request body", required = true) @RequestBody | ||
@Validated MergeLaunchesRQ mergeLaunchesRQ, @AuthenticationPrincipal ReportPortalUser user) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'mergeLaunchesRQ' must contain no more than '1' consecutive capital letters.
@@ -129,4 +136,31 @@ public LaunchResource mergeLaunches(@PathVariable String projectName, | |||
); | |||
} | |||
|
|||
@HttpLogging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a Javadoc comment.
description = "Successful response with dates in timestamp format. " | ||
+ "Response with dates in ISO-8601 format if the custom header " | ||
+ "'Accept: application/x.reportportal.launch.v2+json' is used.", | ||
content = @Content(mediaType = "application/json", schema = @Schema(implementation = LaunchResourceOld.class)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 116).
) | ||
public LaunchResourceOld mergeLaunchesOldUuid(@PathVariable String projectName, | ||
@Parameter(description = "Merge launches request body", required = true) @RequestBody | ||
@Validated MergeLaunchesRQ mergeLaunchesRQ, @AuthenticationPrincipal ReportPortalUser user) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'mergeLaunchesRQ' must contain no more than '1' consecutive capital letters.
No description provided.