Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPMRPP-96944 || Add tracking event when user changes instance invitation settings #2105

Merged
merged 2 commits into from
Nov 22, 2024
Merged

EPMRPP-96944 || Add tracking event when user changes instance invitation settings #2105

merged 2 commits into from
Nov 22, 2024

Conversation

pbortnik
Copy link
Collaborator

No description provided.

@pbortnik pbortnik requested a review from avarabyeu as a code owner November 22, 2024 14:40
github-actions[bot]
github-actions bot reviewed Nov 22, 2024
View reviewed changes
src/main/java/com/epam/ta/reportportal/core/events/activity/util/ActivityDetailsUtil.java
@@ -32,6 +32,8 @@ private ActivityDetailsUtil() {
}

public static final String NAME = "name";

public static final String VALUE = "value";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/events/activity/util/ActivityDetailsUtil.java
@@ -32,6 +32,8 @@
}

public static final String NAME = "name";

public static final String VALUE = "value";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 8, expected level should be 2.

src/main/java/com/epam/ta/reportportal/core/events/activity/SettingsUpdatedEvent.java
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.epam.ta.reportportal.core.events.activity;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck> reported by reviewdog 🐶
'package' should be separated from previous line.

src/main/java/com/epam/ta/reportportal/core/events/activity/SettingsUpdatedEvent.java
import com.epam.ta.reportportal.entity.activity.EventPriority;
import com.epam.ta.reportportal.entity.activity.EventSubject;

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

@pbortnik pbortnik merged commit 165d652 into develop Nov 22, 2024
6 checks passed
@pbortnik pbortnik deleted the EPMRPP-96944 branch November 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@avarabyeu avarabyeu Awaiting requested review from avarabyeu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pbortnik