Add a timeout to HTTP POST connects and reads #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both timeout are hardcoded to 10 seconds. Later commits will make this configurable. This doesn't put a timeout around _all_ of the HTTP POST requests in the codebase.
|
Total noobie here... but this seemed like some low hanging fruit. It's not fully comprehensive, so I hesitate to claim it completely fixes #170, but that is a motivating factor here.. |
HardNorth
requested changes
Apr 5, 2022
|
I went with adding timeouts to the GETs as well as the POSTs. |
HardNorth
approved these changes
Apr 6, 2022
|
@rb1 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both timeout are hardcoded to 10 seconds. Later commits will make this
configurable.
This doesn't put a timeout around all of the HTTP POST requests
in the codebase.