Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip removing small fastq.gz files after the length filter with --list or --sample #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarieLataretu
Copy link
Collaborator

Hi folks,

We have been using --fastq_pass --samples as input configuration, but we will switch to --fastq --list at some point. While testing, I noticed that the negative control didn't appear in the reports.

Now, I'm not sure if I understand the reasoning behind these lines completely: https://github.com/replikation/poreCov/blob/master/modules/filter_fastq_by_length.nf#L34-L36

However, we'd still like to have the negative control in the report, so with this PR, the removal of small fastq.gz files after the length filter is skipped with --list or --sample.

@replikation
Copy link
Owner

When using the e.g. 96 barcode kit you get tons of "false" barcodes. thats why we remove the small ones.

@hoelzer
Copy link
Collaborator

hoelzer commented Dec 20, 2024

True, but I see that this is a problem when a negative control is included (which should have few reads, but people want to see it in the report)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants