skip removing small fastq.gz files after the length filter with --list or --sample #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
We have been using
--fastq_pass --samples
as input configuration, but we will switch to--fastq --list
at some point. While testing, I noticed that the negative control didn't appear in the reports.Now, I'm not sure if I understand the reasoning behind these lines completely: https://github.com/replikation/poreCov/blob/master/modules/filter_fastq_by_length.nf#L34-L36
However, we'd still like to have the negative control in the report, so with this PR, the removal of small fastq.gz files after the length filter is skipped with
--list
or--sample
.