-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table style updates #213
Table style updates #213
Conversation
how does the table decide if it's showing mutations or not?. E.g. barcode 18 shows some barcode 16 not |
I just opened one to show how it looks Should we use some threshold to decide if we want a toggle or not? |
Really nice! Also with the "Collapse|Expand" buttons.
I would just collapse all. Looks most clean then, or? Might cause confusion if some are expanded (e.g. bc/ mutations <=10) and some are not? |
Agreed concerning doing the same for the other columns: It would require more JS magic than I know to do the expand/collapse all buttons column-wise - but it would be easy to make them switch the whole table at once - is that good enough? |
ah yes missed the small triangle yep than i have nothing to complain ;) really good work and yes hide all sorry for my confusion |
i think the whole table doing expand collapse would also be fine. because we just need A) a table (collapsed) so people can quickly go through to check what variant QC etc. and then B) if more details are needed they can expand. so we don't need to overengineer it. |
fancy! : ) |
niceeee. will do some tests today to get this improvement out |
Trying to improve table readability (implements #207)
Play with it here:
poreCov_summary_report_2022-02-08--15-07-12.zip