Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table style updates #213

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Conversation

RaverJay
Copy link
Collaborator

@RaverJay RaverJay commented Feb 8, 2022

Trying to improve table readability (implements #207)

image

  • Mutations are now toggled, hidden by default
  • font size is smaller in main table
  • random tweaks to colnames, linebreaks, etc

Play with it here:
poreCov_summary_report_2022-02-08--15-07-12.zip

@replikation
Copy link
Owner

replikation commented Feb 8, 2022

how does the table decide if it's showing mutations or not?. E.g. barcode 18 shows some barcode 16 not

@RaverJay
Copy link
Collaborator Author

RaverJay commented Feb 8, 2022

how does the table decide if it's showing mutations or not?. E.g. barcode 18 shows some barcode 16 not

  • Mutations are now toggled, hidden by default

I just opened one to show how it looks

Should we use some threshold to decide if we want a toggle or not?
e.g. show them all anyways if there are <= 10 or something

@hoelzer
Copy link
Collaborator

hoelzer commented Feb 8, 2022

Really nice! Also with the "Collapse|Expand" buttons.

Should we use some threshold to decide if we want a toggle or not?
e.g. show them all anyways if there are <= 10 or something

I would just collapse all. Looks most clean then, or? Might cause confusion if some are expanded (e.g. bc/ mutations <=10) and some are not?

@RaverJay
Copy link
Collaborator Author

RaverJay commented Feb 8, 2022

Agreed

concerning doing the same for the other columns:

It would require more JS magic than I know to do the expand/collapse all buttons column-wise - but it would be easy to make them switch the whole table at once - is that good enough?

@replikation
Copy link
Owner

ah yes missed the small triangle yep than i have nothing to complain ;) really good work and yes hide all sorry for my confusion

@replikation
Copy link
Owner

i think the whole table doing expand collapse would also be fine. because we just need A) a table (collapsed) so people can quickly go through to check what variant QC etc. and then B) if more details are needed they can expand. so we don't need to overengineer it.

@RaverJay
Copy link
Collaborator Author

RaverJay commented Feb 8, 2022

Nevermind, I got it done :)

image

@hoelzer
Copy link
Collaborator

hoelzer commented Feb 8, 2022

fancy! : )

@replikation
Copy link
Owner

replikation commented Feb 9, 2022

niceeee.

will do some tests today to get this improvement out

@replikation replikation linked an issue Feb 9, 2022 that may be closed by this pull request
@replikation replikation merged commit beab36a into replikation:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve table style
3 participants