-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a couple of bugs in the base64 file_encoding_strategy #398
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ def encode_json( | |
return encode_json(file, client, file_encoding_strategy) | ||
if isinstance(obj, io.IOBase): | ||
if file_encoding_strategy == "base64": | ||
return base64.b64encode(obj.read()).decode("utf-8") | ||
return base64_encode_file(obj) | ||
else: | ||
return client.files.create(obj).urls["get"] | ||
if HAS_NUMPY: | ||
|
@@ -77,9 +77,13 @@ async def async_encode_json( | |
] | ||
if isinstance(obj, Path): | ||
with obj.open("rb") as file: | ||
return encode_json(file, client, file_encoding_strategy) | ||
return await async_encode_json(file, client, file_encoding_strategy) | ||
if isinstance(obj, io.IOBase): | ||
return (await client.files.async_create(obj)).urls["get"] | ||
if file_encoding_strategy == "base64": | ||
# TODO: This should ideally use an async based file reader path. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This probably isn't too hard if we're prepared to take a dep on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. |
||
return base64_encode_file(obj) | ||
else: | ||
return (await client.files.async_create(obj)).urls["get"] | ||
if HAS_NUMPY: | ||
if isinstance(obj, np.integer): # type: ignore | ||
return int(obj) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lolwut. how did this ever work? did it just... not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did not.